From 1ab57fe316c9425e96d5eec28decb8a99d1ffffa Mon Sep 17 00:00:00 2001
From: David Lenfesty <lenfesty@ualberta.ca>
Date: Fri, 16 Jun 2023 16:28:55 -0600
Subject: [PATCH] tweaked container

---
 .devcontainer/devcontainer.json | 2 +-
 Dockerfile                      | 2 +-
 README.md                       | 5 +++++
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index 2f9e7be..c7dc846 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -9,5 +9,5 @@
 		"dockerfile": "../Dockerfile"
 	},
 
-	"runArgs": ["--privileged"]
+	"privileged": true
 }
diff --git a/Dockerfile b/Dockerfile
index 13e8afa..c69ade7 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -3,7 +3,7 @@ FROM ubuntu:22.04
 WORKDIR /litex
 
 # Install dependencies
-RUN apt-get update && apt-get install -y wget curl python3 python3-pip git gcc-riscv64-linux-gnu ninja-build
+RUN apt-get update && apt-get install -y wget curl python3 python3-pip python3-venv git gcc-riscv64-linux-gnu ninja-build
 # TODO consolidate curl and wget
 RUN pip3 install numpy matplotlib
 
diff --git a/README.md b/README.md
index 6e1135a..f601925 100644
--- a/README.md
+++ b/README.md
@@ -109,3 +109,8 @@ Do I have ecpdap installed in two places and one of them doesn't work maybe?
 
 I do have two versions installed. one from oss-cad-suite and one by building it
 manually.
+
+### Pip install makes UNKNOWN package in docker
+
+This is some weird conflict between pip's setuptools and the system setuptools,
+to solve just set everything up in a venv.